FEEvaluationBase::read_write_operation case 3: enable masking #14085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Jul 3, 2022
|
I don't think we have graphs online yet, but the data from https://dealii.org/performance_tests/results/ suggests that this commit makes step-37/matvec_double and step-37/matvec_float by about 2% slower. I am not entirely sure why this is so drastic, but we should keep an eye on this one. |
|
The slowdown is now tracked in #14098, so we do not need to have a look at this closed PR. |
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
…masking FEEvaluationBase::read_write_operation case 3: enable masking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @bergbauer