FEEvaluationBase::read_write_operation Chose correct code path for neighbors and activated mask #14119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Jul 8, 2022
kronbichler
approved these changes
Jul 8, 2022
|
/rebuild |
|
I think we should have the test in a separate PR. This is something I would like to get evaluated now in terms of performance. |
I will add a test in a follow up! |
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
FEEvaluationBase::read_write_operation Chose correct code path for neighbors and activated mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #14085
This PR selects the correct code path for both masking and neighbor evaluation.
@peterrum @kronbichler