Clean cgal utilities #14097
Merged
Clean cgal utilities #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdrmrc
force-pushed
the
cgal-clean_utilities
branch
5 times, most recently
from
6b890a9
to
ecdc8fa
Compare
|
/rebuild |
fdrmrc
force-pushed
the
cgal-clean_utilities
branch
2 times, most recently
from
b8cf802
to
b0d8f41
Compare
fdrmrc
force-pushed
the
cgal-clean_utilities
branch
from
b0d8f41
to
3e2491b
Compare
luca-heltai
approved these changes
Aug 23, 2022
|
LGTM. If nobody objects, I'll merge in a couple of days. |
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Clean cgal utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans a little the CGAL utilities already available. To minimize code duplication, I added
mapped_quadrature( const std::vector<std::array<Point<spacedim>, dim + 1>> &simplices)that takes a vector of simplices (each one identified by the array of its vertices) and computes a global quadrature rule on the polygon/polyhedron.
Only one test was affected, and it has been modified accordingly.
I'd like to provide a clean interface, before adding the necessary functions for 1D/2D, 1D/3D and 2D/3D coupling, that I have locally