Add test for FEEvaluationShift with FE_Q and FE_DGQ #14131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
reviewed
Jul 13, 2022
bergbauer
force-pushed
the
test_fe_eval_shift
branch
from
433fdb0
to
cfe10ef
Compare
bergbauer
changed the title
|
/rebuild |
peterrum
approved these changes
Jul 14, 2022
tamiko
approved these changes
Jul 16, 2022
|
/rebuild |
kronbichler
reviewed
Jul 18, 2022
Comment on lines
+133
to
+139
| if (shape_info != nullptr) | ||
| { | ||
| AssertDimension(shape_info->n_q_points, this->data->n_q_points); | ||
| AssertDimension(shape_info->dofs_per_component_on_cell, | ||
| this->data->dofs_per_component_on_cell); | ||
| this->data = shape_info; | ||
| } |
There was a problem hiding this comment.
You're not using this path of the code, do you? Do you want to extend the test to also make use of a ShapeInfo evaluated outside of the cell?
There was a problem hiding this comment.
Yes this is a good idea!
bergbauer
force-pushed
the
test_fe_eval_shift
branch
from
cfe10ef
to
492eaf4
Compare
kronbichler
approved these changes
Jul 22, 2022
mkghadban
pushed a commit
to OpenFCST/dealii
that referenced
this pull request
Sep 8, 2022
Add test for FEEvaluationShift with FE_Q and FE_DGQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from #14119 (review)