Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use --date=iso-strict in DEAL_II_QUERY_GIT_INFORMATION #14204

Closed
wants to merge 1 commit into from
Closed

Do not use --date=iso-strict in DEAL_II_QUERY_GIT_INFORMATION #14204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmake/macros/macro_deal_ii_query_git_information.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ MACRO(DEAL_II_QUERY_GIT_INFORMATION)
# Format options for git log:
# %H - the full sha1 hash of the commit, aka "revision"
# %h - the abbreviated sha1 hash of the commit, aka "shortrev"
# %cd - the commit date (for which we use the strict iso date format)
# %cd - the commit date (for which we use the default date format)
#

EXECUTE_PROCESS(
COMMAND ${GIT_EXECUTABLE} log -n 1 --pretty=format:"revision=%H, shortrev=%h, date=%cd" --date=iso-strict
COMMAND ${GIT_EXECUTABLE} log -n 1 --pretty=format:"revision=%H, shortrev=%h, date=%cd" --date=default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not switch to default here. The reason for "iso-strict" here is to get a parseable output: 2022-08-04T13:22:13-04:00.

Default output produces probably a locale dependent string - which is a nightmare.

Would you mind testing #14206 which avoids the option for all git versions older than 2.2.

WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
OUTPUT_VARIABLE _info
RESULT_VARIABLE _result
Expand Down