[9.4] Take over #14540 and #14544 #14545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gmsh library is installed but the gmsh executable is missing we currently disable gmsh support. This implies that we will not link against the gmsh library. Unfortunately, on first configure pass the variable `GMSH_WITH_API` is still populated with a `TRUE` value and the `DEAL_II_GMSH_WITH_API` variable gets set by accident and final linkage fails. This issue is hard to spot because a second invocation of cmake will cure the configure mistake (and the debian/ubuntu packages do not run any autodetection).
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32c0237 (Matthias Maier, 14 minutes ago)
harden DEAL_II_GMSH_WITH_API ifdef
df39dee (Matthias Maier, 25 minutes ago)
CMake: Bugfix: only export DEAL_II_GMSH_WITH_API if gmsh is configured
e58c2eb (Matthias Maier, 25 hours ago)
CMake: Ensure we use "-pthread" instead of "-lpthread" for thread support