Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.4] Take over #14540 and #14544 #14545

Closed
wants to merge 3 commits into from
Closed

[9.4] Take over #14540 and #14544 #14545

wants to merge 3 commits into from

Commits on Dec 8, 2022

  1. CMake: Ensure we use "-pthread" instead of "-lpthread" for thread sup… 

    …port
    @tamiko
    tamiko committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e58c2eb View commit details
    Browse the repository at this point in the history

  2. CMake: Bugfix: only export DEAL_II_GMSH_WITH_API if gmsh is configured 

    If the gmsh library is installed but the gmsh executable is missing we
currently disable gmsh support. This implies that we will not link
against the gmsh library.

Unfortunately, on first configure pass the variable `GMSH_WITH_API` is
still populated with a `TRUE` value and the `DEAL_II_GMSH_WITH_API`
variable gets set by accident and final linkage fails.

This issue is hard to spot because a second invocation of cmake will
cure the configure mistake (and the debian/ubuntu packages do not run
any autodetection).
    @tamiko
    tamiko committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    df39dee View commit details
    Browse the repository at this point in the history

  3. harden DEAL_II_GMSH_WITH_API ifdef

    @tamiko
    tamiko committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    32c0237 View commit details
    Browse the repository at this point in the history