Select correct code path for neighbor elements in FEEvaluation #14903
Conversation
| @@ -3370,9 +3370,11 @@ FEEvaluationBase<dim, n_components_, Number, is_face, VectorizedArrayType>:: | |||
| *this->dof_info); | |||
| } | |||
|
|
|||
| const bool is_neighbor_cells = !is_face && !this->is_interior_face(); | |||
There was a problem hiding this comment.
I know this is pre-existing due to #14119, but I must say that the name is really confusing. How about using use_unsorted_cells? (I am not super happy to have an additional statement in the critical path also for the contiguous storage case. I think we need to work on reducing overhead in the near future.)
There was a problem hiding this comment.
You could also add an additional code comment. I had to look up in many places why we combine !is_face with information on a face, is_interior_face().
There was a problem hiding this comment.
I think we could avoid this by setting this->cell = numbers::invalid_unsigned_int in FEEvaluationShift
Would you prefer this solution?
There was a problem hiding this comment.
Yes, I think that would be better, as the information does not make sense anyway.
bergbauer
force-pushed
the
neighboring_cell_code_path
branch
from
8cb7bf1
to
e458bde
Compare
No description provided.