Build both focal and jammy images. #15074
Conversation
|
In reference to #15060. With this, we would build both jammy and focal images. |
|
dealii/.github/workflows/docker.yml Line 15 in c0a88ee I changed this line in #15060 to make sure we build the focal image on ubuntu-focal. When building the jammy image, I would suggest to create an entirely new job and specifically ask for |
Why is that important? It shouldn't matter what the host system is. |
You are right, it doesn't matter. My conception on how to build docker images was wrong, and it's clear now after reading more about their creation. It's only important what's in the image/container, and not on the host.
|
| git clone https://github.com/dealii/dealii dealii-$VER && \ | ||
| cd dealii-$VER && \ |
There was a problem hiding this comment.
| git clone https://github.com/dealii/dealii dealii-$VER && \ | |
| cd dealii-$VER && \ | |
| git clone https://github.com/dealii/dealii && \ | |
| cd dealii && \ |
We ship each image with only one version of deal.II, right? To keep all images in the same structure, I would suggest to keep the filenames of the source directories the same as well. This way users really need to only switch the docker image if they want to mess with source code of different versions.
I like the VER argument though! It's an easy way to prepare images on different branches/versions.
There was a problem hiding this comment.
We only ever use the source directory when debugging. The actual library is installed in /usr/local for all images, and that's all we really need to know about. I think there is value in distinguishing one version from the other and to allow multiple versions of the source, but if you feel strongly about this, I'll make the change you suggest.
There was a problem hiding this comment.
No, I don't feel strongly about it.
Build both focal and jammy versions of the master branch.