Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ubuntu image in docker.yml. #15092

Merged
merged 1 commit into from Apr 14, 2023
Merged

Conversation

marcfehling
Copy link
Member

OS of the host system is not important.

Refers to #15060 (comment) and #15074 (comment).

OS of the host system is not important.
Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try this. But different version of ubuntu might have different modules shipped.

@marcfehling
Copy link
Member Author

marcfehling commented Apr 14, 2023

This PR reverts a change in #15060 and puts ubuntu-latest in place as before.

As @tjhei pointed out in #15074 (comment), the OS of the host system is not important when building the docker image. The yaml script enhances a pre-existing image with all necessary modules, i.e. dealii/dependencies:focal. So the proper OS and corresponding modules are already there, the deal.II installation will be added and then the image will be uploaded to dockerhub. (Please correct me if my conception of the whole docker workflow is still wrong.)

@marcfehling
Copy link
Member Author

Since #15060, the github-docker workers got aborted as no workers were available.

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Other workers pass, so this leaves me puzzled. This is just a shot in the dark, but maybe the change to ubuntu-20.04 is responsible for that. One more reason to merge this PR quickly...

@marcfehling marcfehling merged commit 40a8507 into dealii:master Apr 14, 2023
11 of 14 checks passed
@marcfehling marcfehling deleted the docker branch April 14, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants