Update tests #15360
Merged
Update tests #15360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jun 14, 2023
| @@ -47,7 +47,8 @@ test() | |||
| } | |||
| catch (ExceptionBase &e) | |||
| { | |||
| deallog << e.what() << std::endl; | |||
| deallog << "Successfully failed to distribute DoFs with a single " | |||
Comment on lines
-59
to
+62
| entries.emplace_back(rand() % 10, rand() % 100); | ||
| { | ||
| const auto row = Testing::rand() % 10; | ||
| const auto col = Testing::rand() % 100; | ||
| entries.emplace_back(row, col); |
There was a problem hiding this comment.
It took me a minute to see the difference -- nice catch!
1. Be more careful about sequence points 2. Use Testing::rand()
For some reason this doesn't work in debug mode. When we require C++17 we can use proper inline constexpr variables so its not worth bothering with a proper fix.
|
The PETSc TS tests now fail to run for me (I'm using a recent development copy of PETSc). For now I just removed them from this PR. |
masterleinad
approved these changes
Jun 15, 2023
What do you mean fail to run? It could be good to know why they are failing |
|
For |
@drwells I don't understand the reasons for the failures. May I ask you to provide the output of the tests with the following options?
You can add them in an environment variable |
|
This has tested cleanly, and I think it is clearly a positive step, so I'm going to merge. @drwells Can you open a report about whatever you think is still open regarding the comments you have above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of tests which fail for trivial reasons - I fixed a bunch here.