Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #15360

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Update tests #15360

merged 3 commits into from
Jun 16, 2023

Commits on Jun 15, 2023

  1. tests: fix call to rand(). 

    1. Be more careful about sequence points
2. Use Testing::rand()
    @drwells
    drwells committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dc9d399 View commit details
    Browse the repository at this point in the history

  2. tests: Avoid a test link error. 

    For some reason this doesn't work in debug mode. When we require C++17
we can use proper inline constexpr variables so its not worth bothering
with a proper fix.
    @drwells
    drwells committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8f483e0 View commit details
    Browse the repository at this point in the history

  3. Don't print exc.what(): it isn't portable.

    @drwells
    drwells committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    49dae80 View commit details
    Browse the repository at this point in the history