Testsuite: fix gmsh tests #15388
Merged
Testsuite: fix gmsh tests #15388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jun 20, 2023
Comment on lines
+25
to
+28
| main(int argc, char **argv) | ||
| { | ||
| // gmsh might be build with mpi support enabled. | ||
| Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv); |
There was a problem hiding this comment.
Why is this necessary? These tests aren't run under MPI, are they?
There was a problem hiding this comment.
@bangerth When you build gmsh with MPI support then gmsh is running under an MPI context.
Test failure: https://cdash.dealii.org/test/22159767
*** The MPI_Comm_rank() function was called after MPI_FINALIZE was invoked.
*** This is disallowed by the MPI standard.
*** Your MPI job will now abort.
[testsuite:1942435] Local abort after MPI_FINALIZE started completed successfully, but am not able to aggregate error messages, and not able to guarantee that all other processes were killed!
There was a problem hiding this comment.
oops I forgot to copy the commit message into the pull request description.
There was a problem hiding this comment.
I see. Thanks for the clarification!
bangerth
approved these changes
Jun 20, 2023
masterleinad
approved these changes
Jun 20, 2023
kronbichler
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #15383