Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testsuite: fix gmsh tests #15388

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Testsuite: fix gmsh tests #15388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80198a3
Test gmsh/gmsh_api*: add MPI_InitFinalize which is necessary if gmsh …
tamiko Jun 20, 2023
b657ecc
Test gmsh/gmsh_api_04: add test output variant
tamiko Jun 20, 2023
bd67561
gmsh/gmsh_api_05: add test variant
tamiko Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/gmsh/gmsh_api_01.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
#include "../tests.h"

int
main()
main(int argc, char **argv)
{
// gmsh might be build with mpi support enabled.
Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv);
Comment on lines +25 to +28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? These tests aren't run under MPI, are they?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bangerth When you build gmsh with MPI support then gmsh is running under an MPI context.
Test failure: https://cdash.dealii.org/test/22159767

*** The MPI_Comm_rank() function was called after MPI_FINALIZE was invoked.
*** This is disallowed by the MPI standard.
*** Your MPI job will now abort.
[testsuite:1942435] Local abort after MPI_FINALIZE started completed successfully, but am not able to aggregate error messages, and not able to guarantee that all other processes were killed!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I forgot to copy the commit message into the pull request description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the clarification!

initlog();

const unsigned int dim = 2;
Expand Down
4 changes: 3 additions & 1 deletion tests/gmsh/gmsh_api_02.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ test(const std::uint8_t kind, const std::string out = "")
}

int
main()
main(int argc, char **argv)
{
// gmsh might be build with mpi support enabled.
Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv);
initlog();

// Generate and print all reference cells
Expand Down
4 changes: 3 additions & 1 deletion tests/gmsh/gmsh_api_03.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ test(const Triangulation<dim, spacedim> &tria)


int
main()
main(int argc, char **argv)
{
// gmsh might be build with mpi support enabled.
Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv);
initlog();
{
Triangulation<2> tria;
Expand Down
4 changes: 3 additions & 1 deletion tests/gmsh/gmsh_api_04.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,10 @@ test(const std::uint8_t kind, const std::string out = "")
}

int
main()
main(int argc, char **argv)
{
// gmsh might be build with mpi support enabled.
Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv);
initlog();

// Generate and print all reference cells
Expand Down