Testsuite: do not compare output for some rpe/* tests #15399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test outputs a mesh with differing results between cgal library versions and underlying standard library. I see at least three different results on the regression tester. Instead of adding three different variants per mpirun, let us simply disable the final comparison and run the test only relying on cgal and our library to throw an error.
This test outputs a mesh with differing results between standard libraries (gnu libstdc++ versus clang/llvm libc++). Instead of adding another output variant for libc++, let us simply disable the final comparison and run the test only relying on cgal and our library to throw an error.
…mpare output Let us also modify the following two tests with all their mpirun variants. I again see slight differences between gcc and clang versions, and between libc++ and libstdc++.
kronbichler
approved these changes
Jun 20, 2023
masterleinad
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following set of tests in remote_point_evaluation/* all print a CGAL mesh whose final order of vertices depends on the compiler, optimization level and standard library being used.
Instead of adding output variants for all tests I ran, let us simply not compare the output. (Tested on two machines, with gcc and clang, libstdc++ and libc++, and differing CGAL versions).
In reference to #15383