Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testsuite: do not compare output for some rpe/* tests #15399

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Testsuite: do not compare output for some rpe/* tests #15399

merged 3 commits into from
Jun 21, 2023

Commits on Jun 20, 2023

  1. Test rpe/convert_intersections_to_rpe_data_02: do not compare output 

    This test outputs a mesh with differing results between cgal library
versions and underlying standard library. I see at least three different
results on the regression tester.

Instead of adding three different variants per mpirun, let us simply
disable the final comparison and run the test only relying on cgal and
our library to throw an error.
    @tamiko
    tamiko committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f13553e View commit details
    Browse the repository at this point in the history

  2. Test rpe/convert_intersections_to_rpe_data_02: do not compare output 

    This test outputs a mesh with differing results between standard
libraries (gnu libstdc++ versus clang/llvm libc++).

Instead of adding another output variant for libc++, let us simply
disable the final comparison and run the test only relying on cgal and
our library to throw an error.
    @tamiko
    tamiko committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4ca2c9f View commit details
    Browse the repository at this point in the history

  3. Test rpe/distributed_compute_intersection_locations_{02,04} do not co… 

    …mpare output

Let us also modify the following two tests with all their mpirun
variants. I again see slight differences between gcc and clang versions,
and between libc++ and libstdc++.
    @tamiko
    tamiko committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1e9d671 View commit details
    Browse the repository at this point in the history