Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTools::categorize_by_boundary_ids: use iterator #15441

Merged
merged 1 commit into from Jun 23, 2023
Merged

MFTools::categorize_by_boundary_ids: use iterator #15441

merged 1 commit into from Jun 23, 2023

Conversation

peterrum
Copy link
Member

references #15440

@peterrum peterrum requested a review from tamiko June 22, 2023 21:01
bangerth
bangerth approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok to merge, but I suspect that it will not fix the problem @tamiko reports.

@bangerth
Copy link
Member

Separately, the loop looks like this:

for (unsigned int i = 0; i < GeometryInfo<dim>::faces_per_cell; ++i)

Are we guaranteed to only be working on quads/hexes in this place?

@bangerth bangerth mentioned this pull request Jun 22, 2023
Merged
@bangerth bangerth added this to the Release 9.5 milestone Jun 22, 2023
@tamiko tamiko merged commit 870d16f into dealii:master Jun 23, 2023
11 of 14 checks passed
@bangerth bangerth mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamiko tamiko tamiko approved these changes

@bangerth bangerth bangerth approved these changes

Assignees
No one assigned
Labels
ready to test Reviewed and ready to merge
Projects
None yet
Milestone
Release 9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterrum @bangerth @tamiko