Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix_free/tools.h: avoid stack use after scope #15444

Closed
wants to merge 1 commit into from

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jun 22, 2023

Avoid dereferencing a TriaIterator temporary so that the underlying
TriaAccessor object remains valid.

In reference to #15383
In reference to #15440

@tamiko tamiko added this to the Release 9.5 milestone Jun 22, 2023
@tamiko
Copy link
Member Author

tamiko commented Jun 22, 2023

@bangerth @peterrum Let us apply the following quick fix so that we don't run into the issue by ordinary use of the library.

@tamiko tamiko closed this Jun 23, 2023
@bangerth bangerth reopened this Jun 23, 2023
@bangerth
Copy link
Member

Why did you close this? This was still a correct patch to fix up a non-idiomatic use of iterators. I would like to see this merged.

@bangerth
Copy link
Member

Wait, was this closed because it is a duplicate of #15441?

@tamiko
Copy link
Member Author

tamiko commented Jun 23, 2023

@bangerth Yes. Closing as duplicate.

@tamiko tamiko closed this Jun 23, 2023
@tamiko tamiko deleted the bandaid_use_after_scope branch July 7, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants