fix step-57 bilinear form #15442
Merged
fix step-57 bilinear form #15442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Jun 22, 2023
Comment on lines
-460
to
+461
| phi_u[i] * (present_velocity_values[q] * | ||
| present_velocity_gradients[q]) + | ||
| phi_u[i] * (present_velocity_gradients[q] * | ||
| present_velocity_values[q]) + |
There was a problem hiding this comment.
Does this mean that we accidentally multiplied by (grad u)^T instead of (grad u)?
|
Just to be extra sure: You tried this and it works again? |
Yes. When the terms got rearranged in #15127, we did not pay attention to the fact that grad_u is a 2-tensor.
Yes. Without this change the program does not converge correctly (debug mode and release mode) and this is the minimal part of the last PR to revert to make it work again. |
drwells
approved these changes
Jun 22, 2023
kronbichler
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of #15127
fixes #15433