Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix step-57 bilinear form #15442

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix step-57 bilinear form #15442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/step-57/step-57.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,8 @@ namespace Step57
local_rhs(i) +=
(-viscosity * scalar_product(grad_phi_u[i],
present_velocity_gradients[q]) -
phi_u[i] * (present_velocity_values[q] *
present_velocity_gradients[q]) +
phi_u[i] * (present_velocity_gradients[q] *
present_velocity_values[q]) +
Comment on lines -460 to +461
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that we accidentally multiplied by (grad u)^T instead of (grad u)?

div_phi_u[i] * present_pressure_values[q] +
phi_p[i] * present_velocity_divergence -
gamma * div_phi_u[i] * present_velocity_divergence) *
Expand Down