Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining deprecations #15629

Merged
merged 9 commits into from
Jul 4, 2023
11 changes: 11 additions & 0 deletions doc/news/changes/incompatibilities/20230703DanielArndt-3
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Removed: The deprecated functions
Triangulation::create_triangulation_compatibility(),
GridTools::cell_measure(),
MappingQCache::initialize(),
TriaAccessor::number_of_children(),
the deprecated class LinearAlgebra::CommunicationPatternBase
and the PETScWrappers::PreconditionerBase alias
have been removed.
<br>
(Daniel Arndt, 2023/07/03)

4 changes: 2 additions & 2 deletions examples/step-1/doc/intro.dox
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ different levels:
every single (member) function in deal.II. You get there if, for
example, you click on the "Main page" or "Classes" tab at the top of
this page. This is the place where you would look up what the second
argument of Triangulation::create_triangulation_compatibility means,
to give just one slightly obscure example. You need this level of
argument of Triangulation::create_triangulation means,
to give just one example. You need this level of
documentation for when you know what you want to do, but forgot how
exactly the function was named, what its arguments are, or what it
returns. Note that you also get into the manual whenever you read
Expand Down
13 changes: 0 additions & 13 deletions include/deal.II/fe/mapping_q_cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,6 @@ class MappingQCache : public MappingQ<dim, spacedim>
initialize(const Mapping<dim, spacedim> & mapping,
const Triangulation<dim, spacedim> &triangulation);

/**
* Initialize the data cache by computing the mapping support points for all
* cells (on all levels) of the given triangulation.
*
* @note The cache is invalidated upon the signal
* Triangulation::Signals::any_change of the underlying triangulation.
*
* @deprecated Use initialize() version above instead.
*/
DEAL_II_DEPRECATED void
initialize(const Triangulation<dim, spacedim> &triangulation,
const MappingQ<dim, spacedim> & mapping);

/**
* Initialize the data cache by letting the function given as an argument
* provide the mapping support points for all cells (on all levels) of the
Expand Down
2 changes: 1 addition & 1 deletion include/deal.II/grid/grid_generator.h
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ namespace GridGenerator
* vectors. Colorizing is done according to hyper_rectangle().
*
* @note This function silently reorders the vertices on the cells to
* lexicographic ordering (see <code>GridReordering::reorder_grid</code>).
* lexicographic ordering (see GridTools::consistently_order_cells()).
* In other words, if reordering of the vertices does occur, the ordering of
* vertices in the array of <code>corners</code> will no longer refer to the
* same triangulation.
Expand Down
4 changes: 2 additions & 2 deletions include/deal.II/grid/grid_in.h
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ struct CellData;
*
* </ul>
*
* <h3>Structure of input grid data. The GridReordering class</h3>
* <h3>Structure of input grid data.</h3>
*
* It is your duty to use a correct numbering of vertices in the cell list,
* i.e. for lines in 1d, you have to first give the vertex with the lower
Expand Down Expand Up @@ -897,7 +897,7 @@ class GridIn
* requirements of the ordering of cells and their faces, i.e. that all
* faces need to have unique directions and specified orientations with
* respect to neighboring cells (see the documentations to this class and
* the GridReordering class).
* the GridTools::consistently_order_cells() function).
*
* The output of this function consists of vectors for each line bounding
* the cells indicating the direction it has with respect to the orientation
Expand Down
19 changes: 0 additions & 19 deletions include/deal.II/grid/grid_tools.h
Original file line number Diff line number Diff line change
Expand Up @@ -253,23 +253,6 @@ namespace GridTools
#endif
));

/**
* Given a list of vertices (typically obtained using
* Triangulation::get_vertices) as the first, and a list of vertex indices
* that characterize a single cell as the second argument, return the
* measure (area, volume) of this cell. If this is a real cell, then you can
* get the same result using <code>cell-@>measure()</code>, but this
* function also works for cells that do not exist except that you make it
* up by naming its vertices from the list.
*
* @deprecated Use the more general function which takes an ArrayView instead.
*/
template <int dim>
DEAL_II_DEPRECATED double
cell_measure(
const std::vector<Point<dim>> &all_vertices,
const unsigned int (&vertex_indices)[GeometryInfo<dim>::vertices_per_cell]);

/**
* Given a list of vertices (typically obtained using
* Triangulation::get_vertices()) as the first, and a list of vertex indices
Expand Down Expand Up @@ -3841,8 +3824,6 @@ namespace GridTools

} /*namespace GridTools*/



/* ----------------- Template function --------------- */

#ifndef DOXYGEN
Expand Down
13 changes: 0 additions & 13 deletions include/deal.II/grid/persistent_tria.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,6 @@ class PersistentTriangulation : public Triangulation<dim, spacedim>
const TriangulationDescription::Description<dim, spacedim>
&construction_data) override;

/**
* An overload of the respective function of the base class.
*
* Throw an error, since this function is not useful in the context of this
* class.
*/
DEAL_II_DEPRECATED
virtual void
create_triangulation_compatibility(
const std::vector<Point<spacedim>> &vertices,
const std::vector<CellData<dim>> & cells,
const SubCellData & subcelldata) override;

/**
* Write all refine and coarsen flags to the ostream @p out.
*/
Expand Down
15 changes: 0 additions & 15 deletions include/deal.II/grid/tria.h
Original file line number Diff line number Diff line change
Expand Up @@ -1893,21 +1893,6 @@ class Triangulation : public Subscriptor
const TriangulationDescription::Description<dim, spacedim>
&construction_data);

/**
* For backward compatibility, only. This function takes the cell data in
* the ordering as requested by deal.II versions up to 5.2, converts it to
* the new (lexicographic) ordering and calls create_triangulation().
*
* @note This function internally calls create_triangulation and therefore
* can throw the same exception as the other function.
*/
DEAL_II_DEPRECATED
virtual void
create_triangulation_compatibility(
const std::vector<Point<spacedim>> &vertices,
const std::vector<CellData<dim>> & cells,
const SubCellData & subcelldata);

/**
* Revert or flip the direction_flags of a dim<spacedim triangulation, see
* @ref GlossDirectionFlag.
Expand Down
23 changes: 0 additions & 23 deletions include/deal.II/grid/tria_accessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -1033,13 +1033,6 @@ class TriaAccessor : public TriaAccessorBase<structdim, dim, spacedim>
unsigned int
n_children() const;

/**
* @deprecated Use n_active_descendants() instead.
*/
DEAL_II_DEPRECATED
unsigned int
number_of_children() const;

/**
* Compute and return the number of active descendants of this objects. For
* example, if all of the eight children of a hex are further refined
Expand Down Expand Up @@ -2206,14 +2199,6 @@ class TriaAccessor<0, dim, spacedim>
static unsigned int
n_active_descendants();

/**
* @deprecated Use n_active_descendants() instead.
*/
DEAL_II_DEPRECATED
static unsigned int
number_of_children();


/**
* Return the number of times that this object is refined. Always 0.
*/
Expand Down Expand Up @@ -2881,14 +2866,6 @@ class TriaAccessor<0, 1, spacedim>
static unsigned int
n_active_descendants();

/**
* @deprecated Use n_active_descendants() instead.
*/
DEAL_II_DEPRECATED
static unsigned int
number_of_children();


/**
* Return the number of times that this object is refined. Always 0.
*/
Expand Down
27 changes: 0 additions & 27 deletions include/deal.II/grid/tria_accessor.templates.h
Original file line number Diff line number Diff line change
Expand Up @@ -1969,15 +1969,6 @@ TriaAccessor<structdim, dim, spacedim>::max_refinement_depth() const



template <int structdim, int dim, int spacedim>
unsigned int
TriaAccessor<structdim, dim, spacedim>::number_of_children() const
{
return n_active_descendants();
}



template <int structdim, int dim, int spacedim>
unsigned int
TriaAccessor<structdim, dim, spacedim>::n_active_descendants() const
Expand Down Expand Up @@ -2751,15 +2742,6 @@ TriaAccessor<0, dim, spacedim>::n_children()



template <int dim, int spacedim>
inline unsigned int
TriaAccessor<0, dim, spacedim>::number_of_children()
{
return 0;
}



template <int dim, int spacedim>
inline unsigned int
TriaAccessor<0, dim, spacedim>::n_active_descendants()
Expand Down Expand Up @@ -3205,15 +3187,6 @@ TriaAccessor<0, 1, spacedim>::n_children()



template <int spacedim>
inline unsigned int
TriaAccessor<0, 1, spacedim>::number_of_children()
{
return 0;
}



template <int spacedim>
inline unsigned int
TriaAccessor<0, 1, spacedim>::n_active_descendants()
Expand Down
2 changes: 1 addition & 1 deletion include/deal.II/grid/tria_levels.h
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ namespace internal
* parallel normal vectors. (For both things, see the paper by
* Agelek, Anderson, Bangerth, Barth in the ACM Transactions on
* Mathematical Software mentioned in the documentation of the
* GridReordering class.)
* GridTools::consistently_order_cells() function.)
*
* The problem is that we originally had another condition, namely that
* faces 0, 2 and 4 have normals that point into the cell, while the
Expand Down
39 changes: 0 additions & 39 deletions include/deal.II/lac/communication_pattern_base.h

This file was deleted.

6 changes: 0 additions & 6 deletions include/deal.II/lac/petsc_precondition.h
Original file line number Diff line number Diff line change
Expand Up @@ -1159,12 +1159,6 @@ namespace PETScWrappers
static PetscErrorCode
pcsetup(PC pc);
};

/**
* Alias for backwards-compatibility.
* @deprecated Use PETScWrappers::PreconditionBase instead.
*/
using PreconditionerBase DEAL_II_DEPRECATED = PreconditionBase;
} // namespace PETScWrappers


Expand Down
11 changes: 0 additions & 11 deletions source/fe/mapping_q_cache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -134,17 +134,6 @@ MappingQCache<dim, spacedim>::initialize(



template <int dim, int spacedim>
void
MappingQCache<dim, spacedim>::initialize(
const Triangulation<dim, spacedim> &triangulation,
const MappingQ<dim, spacedim> & mapping)
{
this->initialize(mapping, triangulation);
}



template <int dim, int spacedim>
void
MappingQCache<dim, spacedim>::initialize(
Expand Down
12 changes: 0 additions & 12 deletions source/grid/persistent_tria.cc
Original file line number Diff line number Diff line change
Expand Up @@ -157,18 +157,6 @@ PersistentTriangulation<dim, spacedim>::create_triangulation(



template <int dim, int spacedim>
void
PersistentTriangulation<dim, spacedim>::create_triangulation_compatibility(
const std::vector<Point<spacedim>> &,
const std::vector<CellData<dim>> &,
const SubCellData &)
{
Assert(false, ExcImpossibleInDim(dim));
}



template <int dim, int spacedim>
void
PersistentTriangulation<dim, spacedim>::write_flags(std::ostream &out) const
Expand Down