New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining deprecations #15629
Conversation
1ebabaa
to
630482b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you cleaned up the vertex ordering tests, especially as in getting rid of create_triangulation_compatibility()
. Looked very tedious.
You duplicated some code to ensure mesh compatibility among some tests. I would suggest to move these functions into a separate header file, or extend the existing one tests/test_grids.h
which right now only has mesh generators, but it would be predestined for the vertex reordering. Then we have everything in one spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Technically we could also use these functions on tests/bits/neighboring_cells_at_two_faces.cc
, tests/data/data_out_curved_cells.cc
, tests/grid/grid_invert_02.cc
, and tests/grid/line_coarsening_3d.cc
to preserve the original state of the test. Probably not necessary, I don't feel strong about it. How do you think about it?
I would rather convert all the tests instead of using the new function but that seemed to be too much work. |
Rebased on top of #15611.
Deprecated in: