Split fe_values.h and fe_values.cc into three files each. #15829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
drwells
force-pushed
the
fe-values-split-1
branch
from
12d72d1
to
c79d911
Compare
In 367243a (PR 15575) I removed SPLIT_INSTANTIATIONS_INDEX et al from fe_values.cc. This was fine for -O2 but with -O3 -march=native this file now takes several minutes to compile. The majority of our compilation time here is in FEValuesViews - ultimately I'd like to split that up. This commit performs one step towards splitting that up by splitting up fe_values.h and corresponding source files into files for FEValuesViews, FEValues, and FEValuesBase.
drwells
force-pushed
the
fe-values-split-1
branch
from
c79d911
to
007f257
Compare
luca-heltai
reviewed
Aug 3, 2023
Comment on lines
+35
to
38
| #include <deal.II/fe/fe_values_base.h> | ||
| #include <deal.II/fe/fe_values_extractors.h> | ||
| #include <deal.II/fe/mapping.h> | ||
| #include <deal.II/fe/mapping_related_data.h> |
There was a problem hiding this comment.
Shouldn't we add here also fe_values_views.h to keep backward compatibility with user codes?
There was a problem hiding this comment.
Maybe? What we have now is backwards-compatible because that header file is included by fe_values_base.h. We could add it to be explicit.
Since setting up FEValuesViews objects is the responsibility of the base class I think it should remain a transitive inclusion.
luca-heltai
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 367243a (PR #15575) I removed
SPLIT_INSTANTIATIONS_INDEXet al from fe_values.cc. This was fine for-O2but with-O3 -march=nativethis file now takes several minutes to compile.The majority of our compilation time here is in
FEValuesViews- ultimately I'd like to split that up. This commit performs one step towards splitting that up by splitting up fe_values.h and fe_values.cc into separate files forFEValuesViews,FEValues, andFEValuesBase.Conflicts with #15819.