Move the internal FEValuesViews functions into a new file. #15895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the compilation work for FEValues is actually the inner functions used by FEValuesViews objects. Explicitly instantiating these functions in their own translation unit significantly lowers compilation time. Here are the numbers for release mode: master: - fe_values_views: 7:58 wall time, 4.5 GB max RSS feature: - fe_values_views: 0:32 wall time, 1.6 GB max RSS - fe_values_views_internal: 2:58 wall time, 2.8 GB max RSS I had to adjust the type signatures (on the first ArrayView argument) to avoid instantiating things for 'const float' rather than float et al.
kronbichler
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
This is a nice improvement in memory usage and times, thank you! I am in full support of this. I have some unrelated notes of idioms that were present before but are inefficient - not sure if we care enough about performance to change them, because these functions are having the right data structure to do things efficiently anyway.
kronbichler
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #13949 and #15829.
Most of the compilation work for FEValues is actually the inner functions used by FEValuesViews objects. Explicitly instantiating these functions in their own translation unit significantly lowers compilation time. Here are the numbers for release mode:
master:
this branch:
I had to adjust the type signatures (on the first ArrayView argument) to avoid instantiating things for 'const float' rather than float et al.