Add a version of timing_step_37 using MGTransferMF #15842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
force-pushed
the
timing_step_37_gc
branch
from
1513eb7
to
b66c288
Compare
|
I have rebased this PR. |
tamiko
reviewed
Aug 7, 2023
| "solve", | ||
| "matvec_double", | ||
| "matvec_float", | ||
| "matvec_float_coarser"}}; |
There was a problem hiding this comment.
This test has a significant overlap with the already existing timing_step_37. Would you mind to condense the measurements down to the values we are actually interested in?
There was a problem hiding this comment.
I agree, we should only measure the setup of the transfer and the solver time. Everything else should be equivalent I believe.
peterrum
commented
Aug 18, 2023
| std::tuple<Metric, unsigned int, std::vector<std::string>> | ||
| describe_measurements() | ||
| { | ||
| return {Metric::timing, 4, {"setup_transfer", "solve"}}; |
kronbichler
approved these changes
Aug 22, 2023
|
@tamiko any last opinions on this PR? If not, I will merge tomorrow. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #15794