Fix indentation CI #15929
Merged
Fix indentation CI #15929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
added
High Priority ⚠️
Regression tester
blaisb
approved these changes
Aug 25, 2023
|
@kronbichler and @peterrum . Not sure what's the policy here. I doubt this requires the full Jenkins tests suite, so I'll just wait for another approval to merge. |
peterrum
approved these changes
Aug 25, 2023
|
I would not run it in these cases. I usually try to look whether the Jenkins jobs will be affected by the change at all, leaving documentation changes or tutorial changes out of the Jenkins setup. |
drwells
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging #15842, I did not realize that the PR was not rebased on top of the new indentation/clang-format version, so the CI of the PR did not catch the problem with respect to how we indent now. I got an angry email by github that
masteris failing, which is hopefully fixed by this PR.