Avoid use of old AffineConstraints functions. #16034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only the indent check fails, but for reasons I do not understand (and seem unrelated). Anyone got an idea? |
| * Return the index set describing which part of the degrees of freedom to | ||
| * which this object stores constraints are "locally owned". Typically, | ||
| * these would be the | ||
| * @ref GlossLocallyOwnedDoFs "locally owned degrees of freedom". |
There was a problem hiding this comment.
Suggested change
| * @ref GlossLocallyOwnedDoFs "locally owned degrees of freedom". | |
| * @ref GlossLocallyOwnedDoF "locally owned degrees of freedom". |
should make doxygen happy.
masterleinad
approved these changes
Sep 22, 2023
|
Ah, so close yet oh so far! |
kronbichler
approved these changes
Sep 24, 2023
Merged
bangerth
commented
Sep 27, 2023
Comment on lines
-616
to
+620
| constraints.reinit(index_set); | ||
| constraints.reinit(constraints.get_locally_owned_indices(), index_set); |
There was a problem hiding this comment.
For completeness (in hindsight), this change was wrong. It is fixed in #16053.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to #16032, but for places in the library itself. It turns out that I need access to which DoFs the
AffineConstraintobject considers as "locally owned" in a couple of places, so I'm adding an accessor function.Follow-up to #15789.
In reference to #15375.