Add an assertion. #16053
Merged
Add an assertion. #16053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
reviewed
Sep 27, 2023
source/base/index_set.cc
Outdated
Comment on lines
523
to
525
| Assert(size() == other.size(), | ||
| ExcMessage("One index set can only be a subset of another if they " | ||
| "describe index spaces of the same size.")); |
There was a problem hiding this comment.
Could you print the numbers in the message? Similar to the case of AssertDimension?
|
I pushed a new version of this patch. It also includes a fix for a place where we now trigger this assertion (yay assertions!) that I had accidentally introduced in #16034. Let's see whether that is the only place that I got wrong there. |
masterleinad
approved these changes
Sep 27, 2023
marcfehling
approved these changes
Sep 27, 2023
peterrum
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error in geodynamics/aspect#5398 would have been much more obvious with this assertion here. Might also have made the fix in geodynamics/aspect#5405 easier.