Don't create new sections during parsing #16704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
commented
Feb 29, 2024
Comment on lines
+2
to
+5
| { | ||
| "test 0": "1", | ||
| "test 1": "1" | ||
| } |
There was a problem hiding this comment.
The output looked like this:
{
"test 0": "1",
"test 1": "1",
"test 3": ""
}
bangerth
reviewed
Mar 7, 2024
tests/parameter_handler/prm/parameter_handler_read_json_04.json
Outdated
Show resolved
Hide resolved
Comment on lines
+2
to
+7
| "test 0": "1", | ||
| "test 1": "1", | ||
| "test 2": "1", | ||
| "test 3": { | ||
| "test 4" : "1" | ||
| } |
There was a problem hiding this comment.
I don't understand what is happening with this test. You only declare parameters test 0 and test 1. How come we accept this as a valid input file? Is it because we read the whole file and then go through our own parameters to see which ones have been read, ignoring everything that has been read but does not correspond to our own parameters?
There was a problem hiding this comment.
Exactly. The ignoring works well for the parameters but not for the sections with the result that new sections are created.
peterrum
force-pushed
the
parameterhandler_create_path_if_needed
branch
from
fc403ae
to
f9a83e3
Compare
bangerth
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @mschreter