-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create new sections during parsing #16704
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Improved: The parse functions of ParameterHandler used to add subsections | ||
if subsections/parameters have not been defined. This led to an output | ||
of ParameterHandler::print_parameters() that also contained these subsections. | ||
This is not the case anymore. | ||
<br> | ||
(Peter Munch, Magdalena Schreter-Fleischhacker, 2024/02/12) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// ------------------------------------------------------------------------ | ||
// | ||
// SPDX-License-Identifier: LGPL-2.1-or-later | ||
// Copyright (C) 2020 by the deal.II authors | ||
// | ||
// This file is part of the deal.II library. | ||
// | ||
// Part of the source code is dual licensed under Apache-2.0 WITH | ||
// LLVM-exception OR LGPL-2.1-or-later. Detailed license information | ||
// governing the source code and code contributions can be found in | ||
// LICENSE.md and CONTRIBUTING.md at the top level directory of deal.II. | ||
// | ||
// ------------------------------------------------------------------------ | ||
|
||
|
||
|
||
// check ParameterHandler::parse_input() for json file | ||
|
||
#include <deal.II/base/parameter_handler.h> | ||
|
||
#include "../tests.h" | ||
|
||
|
||
int | ||
main() | ||
{ | ||
initlog(); | ||
|
||
ParameterHandler prm; | ||
|
||
double test_0 = 0; | ||
double test_1 = 0; | ||
|
||
// test if underscore can be parsed | ||
prm.add_parameter("test 0", test_0); | ||
prm.add_parameter("test 1", test_1); | ||
|
||
std::string source = SOURCE_DIR; | ||
std::string filename = source + "/prm/parameter_handler_read_json_04.json"; | ||
|
||
std::ifstream file; | ||
file.open(filename); | ||
prm.parse_input_from_json(file, true); | ||
|
||
prm.print_parameters(deallog.get_file_stream(), | ||
ParameterHandler::OutputStyle::ShortJSON); | ||
|
||
return 0; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
{ | ||
"test 0": "1", | ||
"test 1": "1" | ||
} | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"test 0": "1", | ||
"test 1": "1", | ||
"test 2": "1", | ||
"test 3": { | ||
"test 4" : "1" | ||
} | ||
Comment on lines
+2
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand what is happening with this test. You only declare parameters There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exactly. The ignoring works well for the parameters but not for the sections with the result that new sections are created. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output looked like this: