testing of step-40 to step-49 #17165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Jun 21, 2024
tests/examples/step-49.diff
Outdated
| 88,91c88,92 | ||
| < std::ofstream out(filename); | ||
| < GridOut grid_out; | ||
| < grid_out.write_vtu(triangulation, out); |
vyushut
force-pushed
the
CTest_step_fourties
branch
from
c4dcabd
to
33152d6
Compare
vyushut
force-pushed
the
CTest_step_fourties
branch
from
33152d6
to
8f32603
Compare
tjhei
reviewed
Jul 3, 2024
tests/examples/step-40.diff
Outdated
| < const unsigned int n_cycles = 8; | ||
| --- | ||
| > const unsigned int n_cycles = 3; | ||
| 662c664 | ||
| 659c661 | ||
| < output_results(cycle); |
There was a problem hiding this comment.
I thought about this some more and I think we should keep all calls to graphical output.
tests/examples/step-43.diff
Outdated
| > // std::cout << " ..." << solver_control.last_step() | ||
| > // << " CG iterations." << std::endl; | ||
| 2161,2162c2170,2171 | ||
| < if (timestep_number % 200 == 0) |
tests/examples/step-44.diff
Outdated
| 1126c1126 | ||
| < output_results(); | ||
| --- | ||
| > // output_results(); |
tests/examples/step-44.diff
Outdated
| --- | ||
| > // output_results(); | ||
| 1543c1543 | ||
| < std::cout << " Setting up quadrature point data..." << std::endl; |
tests/examples/step-45.diff
Outdated
| @@ -0,0 +1,4 @@ | |||
| 768c768 | |||
| < output_results(refinement_cycle); | |||
There was a problem hiding this comment.
I think you did not address this point
There was a problem hiding this comment.
Got it, thanks! Instead of changing tests/examples/step-45.cc and propagating it via update_diffs, I corrected the step-45.diff directly. Needless to say I called update_diffs later for other reason which reversed step-45.cc to the original state...
tests/examples/step-46.diff
Outdated
| < std::cout << " Writing output..." << std::endl; | ||
| < output_results(refinement_cycle); | ||
| --- | ||
| > std::cout << " Writing output..." << std::endl; |
tests/examples/step-47.diff
Outdated
| @@ -0,0 +1,4 @@ | |||
| 905c905 | |||
| < output_results(cycle); | |||
tests/examples/step-49.diff
Outdated
| 91,91c91,92 | ||
| < std::cout << " written to " << filename << std::endl << std::endl; | ||
| --- | ||
| > // std::cout << " written to " << filename << std::endl << std::endl; |
tjhei
approved these changes
Jul 6, 2024
vyushut
force-pushed
the
CTest_step_fourties
branch
from
605d121
to
18d14b4
Compare
This was referenced Jul 9, 2024
kronbichler
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proceeding after #17100, #17084, #17130.
CTests should not write any vtk and, if they output any iteration counts, they should do it with with a range of acceptable answers.