Provide more instantiations for std::complex data types. #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
|
Passes my testsuite, btw. |
kronbichler
approved these changes
Dec 7, 2017
|
@kronbichler -- did you want me to do anything when you approved the patch? Or is it ok as it is? |
|
No, I think it is fine. I was just waiting to see if anyone else has a comment. Since that seems not to be the case, I will merge. |
luca-heltai
pushed a commit
to luca-heltai/dealii
that referenced
this pull request
Dec 8, 2017
Provide more instantiations for std::complex data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to run some more functions like
VectorTools::projectfor complex-valued right hand sides. The changes herein are mostly uncontroversial and so I package them up into a patch of their own -- their just mechanically adding instantiations and then ensuring that things actually compile (and when they don't, to add the necessary template arguments and change data types).The functions I'm instantiating here are mostly for mixed complex-real arithmetic. I need this in
VectorTools::projectand similar places because the mass matrix should remain real, but it's applied to a complex-valued right hand side.Part of #2033.