Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into a function in FE_Q_Base, we initialize an array but do so by first
creating an alias (reference) variable for it and then writing into it.
I'm not a big fan of these alias variables. It makes it more difficult to read
code, and in particular to search code for where a variable is actually
initialized. (This is how I hit on this location.) I recognize that the variable
in question has a pretty long name, and that the lines become longer than we
usually like it, but IDEs typically show substantially more than 100 characters
per line these days, so I think the benefits outweigh the downsides.
This is ultimately a judgment call. The patch reflects my opinion,
but if others feel differently, then we can go that route as well.