Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify exactly which files to package #27

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Specify exactly which files to package #27

merged 1 commit into from
Mar 22, 2016

Conversation

MarkHerhold
Copy link
Contributor

Currently, chai-subset packages the following files up when chai-subset is versioned:

  8B .eslintignore
505B .eslintrc
107B .jscsrc
 59B .npmignore
112B .travis.yml
1.0K LICENSE
1.7K README.md
204B coverage
102B lib
2.2K package.json

Only package.json, README.md, LICENSE, and lib are really needed. Specifying the "files" key in package.json will limit these files, removing the need for .npmignore as well.

https://docs.npmjs.com/files/package.json#files

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c9de021 on MarkHerhold:master into b0de33d on debitoor:master.

@eagleeye
Copy link
Contributor

Great contribution, @MarkHerhold , thanks a lot!

eagleeye added a commit that referenced this pull request Mar 22, 2016
@eagleeye
Merge pull request #27 from MarkHerhold/master
87dcaaa 
Specify exactly which files to package
@eagleeye eagleeye merged commit 87dcaaa into debitoor:master Mar 22, 2016
@eagleeye
Copy link
Contributor

much better now
image
btw chai-subset 1.2.2 is out ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkHerhold @coveralls @eagleeye