fixing the issue that linked types are always a HalResource #25
Conversation
adding lodash for some functional magic
|
I added some handling to be able to serialize embedded arrays correctly. And I added lodash if you don't mind. 😃 |
|
Could this be a part of the solution for #22? |
| @@ -0,0 +1,6 @@ | |||
| root = true | |||
|
|
|||
| [*] | |||
There was a problem hiding this comment.
This file must no be on the project.
There was a problem hiding this comment.
I can remove it. But I suggest you think about using EditorConfig as is makes collaborating way more easier. I use it in my projects all the time. And I guess it's some kind of common sense.
Have a look here: http://editorconfig.org/
| @@ -18,6 +18,7 @@ | |||
| "url": "http://github.com/deblockt/hal-rest-client/issues" | |||
| }, | |||
| "dependencies": { | |||
| "@types/lodash": "^4.14.92", | |||
There was a problem hiding this comment.
Is this lib very usefull?
I'm trying to have a minimal dependency number.
There was a problem hiding this comment.
In my opinion it is. It adds the aspect of functional programming. It makes the code easier to read and to maintain. Since I'm a Java developer, this is something I miss sadly in TypeScript. I understand that you want to keep your footprint as small as possible and I can definitely rewrite the code to be imperative and if you insist, I'll do. But it'll make a tear run down my cheek. ;)
| @@ -147,4 +152,23 @@ export class HalResource implements IHalResource { | |||
|
|
|||
| return json; | |||
| } | |||
|
|
|||
| private serializeProperty(prop, serializer: IJSONSerializer, arrayItem?: any) { | |||
There was a problem hiding this comment.
I don't think this is a correct place for this method.
There are a hal-json-serializer file to serialize objects.
There was a problem hiding this comment.
This is just an extension to serialize(...) . It is just the part that I tool from serialize(...) to make it callable recursively (lines 143-147). And I added the ability to process arrays. Maybe the name should be something else.
Line 143 of the previous version corresponds to line 161. I used some helper methods of lodash to improve readability.
Old line 144 equals new line 162.
So is old line 146 to new line 169. They are the same.
In between is the ability to read arrays (and the recursive call).
|
Thanks for this PR. after add unit test, and some code fix. |
|
@Smolli did you have work on your unit test? |
|
Sorry, not right now. They shifted the focus on another project at work. But I try to get my hands on as soon as possible. |
I was at the point were I was wondering why an embedded HAL resource isn't of the type that it was declared. I debugged and found that little bug. If the HAL name and the TS name don't match, the wrong type is being used. This should fix it.