Checked and fixed possible quoting problems using shellcheck. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still a number of open warnings reported by shellcheck but they are not as easy to fix as quoting. This PR is not really tested and I am not 100 % sure that I did not introduce bugs by this rework. Unfortunately I did not find a tool to do this quite monoton task for me. Related to debops#57 (comment)
|
All those modifications have been made by Yeah, moving repetitive code into separate functions might be needed, although I would release a working version first. And perhaps that could be combined with variable rename. |
Sadly not. As said I could not find a tool to do that task. I did it manually …
Sure. That would be a bigger refactoring to do with the potential of breaking things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a number of open warnings reported by shellcheck but
they are not as easy to fix as quoting.
This PR is not really tested and I am not 100 % sure that I did not
introduce bugs by this rework. Unfortunately I did not find a tool to do
this quite monoton task for me.
Related to
#57 (comment)
@drybjed Looking throught the scripts it seems that there was a but much copy paste involved. I guess we should refactor that?