Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enterprise check for fingerprint scanning #226

Merged
merged 7 commits into from
May 2, 2024
Merged

Add enterprise check for fingerprint scanning #226

merged 7 commits into from
May 2, 2024

Conversation

filip-debricked
Copy link
Collaborator

No description provided.

@filip-debricked filip-debricked force-pushed the 6892-enterprise-check-fingerprinting branch from 93d4552 to b4045cc Compare April 23, 2024 08:42
@filip-debricked filip-debricked self-assigned this Apr 23, 2024
klaradebricked
klaradebricked approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@klaradebricked klaradebricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Let's give the error messages and docs some love and then LGTM :)

@filip-debricked filip-debricked force-pushed the 6892-enterprise-check-fingerprinting branch from 49a048f to 7d16fab Compare April 23, 2024 13:50
@sweoggy sweoggy added this to the 2.0.0 milestone Apr 23, 2024
@sweoggy
Copy link
Member

sweoggy commented Apr 23, 2024

@filip-debricked please add to UPGRADE-2.0.md

@filip-debricked filip-debricked force-pushed the 6892-enterprise-check-fingerprinting branch 7 times, most recently from c12dc48 to 96e3102 Compare April 30, 2024 09:38
@filip-debricked filip-debricked force-pushed the 6892-enterprise-check-fingerprinting branch from 96e3102 to 97ee7ac Compare May 2, 2024 06:09
@filip-debricked filip-debricked force-pushed the 6892-enterprise-check-fingerprinting branch from 97ee7ac to 839d388 Compare May 2, 2024 06:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Large Method scan.go: NewScanCmd 🔥
  • String Heavy Function Arguments deb_client.go

✅ Improving Code Health:

  • String Heavy Function Arguments deb_client_mock.go

@sweoggy sweoggy merged commit 23e06b7 into main May 2, 2024
19 checks passed
@sweoggy sweoggy deleted the 6892-enterprise-check-fingerprinting branch May 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlTern CarlTern CarlTern approved these changes

@klaradebricked klaradebricked klaradebricked approved these changes

Assignees

@filip-debricked filip-debricked

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@filip-debricked @sweoggy @CarlTern @klaradebricked