Fixes to make it work #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully save some folks a bit of trouble with the "Support for Elasticsearch versions after their end-of-life (currently versions < 7.10)" error.
Closed
sweoggy
reviewed
Sep 19, 2022
| @@ -5,15 +5,17 @@ services: | |||
| volumes: | |||
| - ./files:/input:ro | |||
| - ./output_files:/output | |||
| command: parsedmarc -c /parsedmarc.ini /input/* | |||
| command: parsedmarc -c /parsedmarc.ini /input/* --debug | |||
There was a problem hiding this comment.
What is the reason for running with debug flag?
There was a problem hiding this comment.
Sorry, I just forgot about my fork. That was added just to provide at least some feedback to user. Otherwise there is no info about is it working, or just freezed.
|
Thanks for your contribution @Keramblock! Could you rebase on master? |
Fixing esVersion to match Elastic Search version
Just in case you still need it - I resolved conflict. Otherwise feel free to close it and/or copy files necessary for you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thiis is quick fixes to make it, work, tested on my setup, also added volume in docker-compose to preserve elastic data and add debug parsedmarc for better logging. closes #38