Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pepys_import command-line script #84

Closed
robintw opened this issue Feb 19, 2020 · 4 comments · Fixed by #86 or #88
Closed

Create pepys_import command-line script #84

robintw opened this issue Feb 19, 2020 · 4 comments · Fixed by #86 or #88

Comments

@robintw
Copy link
Collaborator

robintw commented Feb 19, 2020

#44 says that we want to run a pepys_import batch script which will run a Python script to call the file processor with the current directory as an argument. We need to write that Python script.

@robintw
Copy link
Collaborator Author

robintw commented Feb 19, 2020

I could probably have a go at this myself, but it might be quicker for @IanMayo or @BarisSari to put something together as they're more familiar with the parsing API at the moment - and that'd allow me to focus on the deployment.

I've seen some examples in the repo, but I'm not sure how up-to-date notebooks like this are - as I think I've seen commits that look like they've changed this API recently.

@BarisSari
Copy link
Contributor

Hi Robin. Unfortunately, these notebooks are not changed completely and they're not working. I was thinking to change all files in the examples/ folder when refactoring is completed.

@IanMayo
Copy link
Member

IanMayo commented Feb 20, 2020

@BarisSari - I don't mind if we delete the notebooks. We can then re-create them once the API has stabilised.

(yes - it would have saved you some refactoring effort if I'd said this two weeks ago, sorry).

@IanMayo
Copy link
Member

IanMayo commented Feb 20, 2020

@robintw - are you aware of a best-practice for where we put both the batch-script and the "top-level" python script?

I guess the batch script could sit in the top-level of the repo, or alternatively in a bin sub-folder. I guess the python import.py file could sit in the top level of the pepys-import module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants