move ms to the last place

[gorangajic]

when you call debug with more than one param ms diff goes to the second place

var debug = require('debug')('OK');
debug('awesome', 'debug', 'message');  

before
OK awesome +0ms debug message

after
OK awesome debug message +0ms

[steelbrain]

👍

[TrejGun]

👍

[mbroadst]

👍

[steelbrain]

I wonder what exactly is stopping us from shipping this.

cc @TooTallNate

[mbroadst]

@steelbrain it may be worth noting that arguments are potentially leaked here, see: https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments

[steelbrain]

@mbroadst I've seen this used in the node core itself (Although they use Array.from instead of Array.prototype.slice.call(arguments) but the concept remains the same), that being said I don't think the performance hit will be significant (unless you have a benchmark proving otherwise)

[gorangajic]

not sure it's worth it but I have updated pull request, so now arguments are not leaked

didn't know about Array.from 👍

[mbroadst]

@steelbrain Array.from I believe will make a new copy of the array, and therefore not leak. I'm not really being a stickler here I was just speculating as to why it hasn't been merged yet :) not to mention the performance hit would be negligible considering debug should be a no-op if you haven't enabled debugging for the given category

@gorangajic Also I'm pretty sure we can't use Array.from here since its ES6 and this needs to target older versions of node?

[mbroadst]

@gorangajic oops, totally wrote that without looking at your code update please ignore the noise!

[steelbrain]

Even though I don't maintain the project, I would still like to hear why i is declared above and not here :)

[mbroadst]

personal preference I'm sure, hoisting and all that

[thebigredgeek]

can you inline the i in the for loop please?

[mbroadst]

@TooTallNate any updates here?

[world]

this is a great bug fix. I have forked from @TooTallNate who may have abandoned debug from what I can tell. Thank you @gorangajic

[mbroadst]

cc @TooTallNate ?

[thebigredgeek]

I am reviewing. Once change is applied I'll gladly merge this

[gorangajic]

@thebigredgeek updated pull request

[thebigredgeek]

@gorangajic merging this. Thanks for the contribution