fix(a11y): correct label "for" references to fields #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit abddc52 |
|
Deploy preview for cms-demo ready! Built with commit abddc52 |
erquhart
approved these changes
Nov 26, 2018
LoicMahieu
added a commit
to LoicMahieu/netlify-cms
that referenced
this pull request
Nov 29, 2018
* official/master: (42 commits) chore: improve publish scripts Publish chore: test before publishing chore(netlify-cms-core): upgrade react-dnd to 7.x (decaporg#1922) chore(netlify-cms-widget-text): upgrade to react-textarea-autosize 7.x (decaporg#1921) chore(netlify-cms-core): upgrade to react-waypoint 8.x (decaporg#1920) fix(backend): use singular label in custom commit message (decaporg#1917) docs: add GAE-specific oAuth client (decaporg#1918) fix(netlify-cms-widget-text): set correct font family (decaporg#1916) chore(netlify-cms-core): upgrade redux and related dependencies (decaporg#1914) chore(dependencies): bump npm-run-all (decaporg#1913) fix(netlify-cms-core): fix identifier field validation (decaporg#1907) docs: improve widget custom validation sample (decaporg#1911) improvement(backends): changes for registerBackend compatibility (decaporg#1880) fix(netlify-cms-core): fix prop-types warnings (decaporg#1906) fix(a11y): correct label "for" references to fields (decaporg#1904) improvement(netlify-cms-core): wrap navigations in lists for better a11y (decaporg#1903) fix(netlify-cms-widget-markdown): add missing border radius on toolbar (decaporg#1905) fix(netlify-cms-core): remove double focusable elements on profile menu button (decaporg#1900) fix(config): remove identifier field validation (decaporg#1882) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partly fixes one of the issues described (labels) in #1333.
Previously a new
forIDwas generated on every render which caused some issues. Now we store a generated id on the class instance instead that never updates (unless the component re-mounts). Also had to make some adjustments in the toggle component to allow it to be controlled from a label.There is still some work to get all the widgets to work properly, like the markdown, file etc. But I think that can be resolved in another PR.
Test plan
Manually tested everything