Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widget-relation): don't invoke onChange if component is not mounted #5804

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Sep 13, 2021

Summary

Fixes #5093
Probably fixes #4891 too

This should fix a race condition in the relation widget, where slower to load entries override faster to load ones when switching between entries.

Test plan

Existing tests

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)
🐱

@erezrokah erezrokah requested a review from a team September 13, 2021 10:22
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Sep 13, 2021
@erezrokah erezrokah merged commit bd35474 into master Sep 13, 2021
@erezrokah erezrokah deleted the fix/relation_widget branch September 13, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
1 participant