ci(workflow): add cache to workflows using actions/setup-node #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
suggested changes
Oct 13, 2021
There was a problem hiding this comment.
Thanks @oscard0m!
Since we're using yarn as our package manager, should we following this https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies?
erezrokah
reviewed
Oct 13, 2021
| check-latest: true | ||
| cache: npm | ||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
Should we remove the existing cache action?
erezrokah
added
the
type: chore
|
Closing the PR per my latest comment as it's relevant for repos using |
Yes, you are totally right. I will apply the changes, I've been a bit busy lately. |
|
Re-opened in a new PR with changes applied: #5924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
cacheto workflows usingactions/setup-nodeContext
setup-nodeGitHub Action just released a new option to add cache to steps using it.You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾