Fix (i18n): Return the Correct Locale from Filenames - fixes #5909 #5922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When determining the locale from the filename in a
i18n.structure: multiple_files
-setup, the code returnedg
for the fileindex.gd.md
. This was due to the use of the lodash-methodtrimEnd
for removing the file extension.As per the lodash docs the
trimEnd
method does not remove the specified string from the end, but instead removes all characters from the end. So in this case when callingit did not just remove the '.md' at the end, as intended, but instead all occurrences of the characters
.
,m
andd
from the end. Thus the result wasindex.g
instead ofindex.gd
.I changed the implementation to use the
String.prototype.slice()
method to remove the number of characters of file extension from the end of the string.This closes #5909.
Test plan
I added jest tests.
Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.