fix: change file-control default value to string #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cms-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
martinjagodic
approved these changes
Oct 10, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
martinjagodic
pushed a commit
to geotrev/netlify-cms
that referenced
this pull request
Oct 17, 2023
|
I think this now leads to new problems as you can see on #7120 and #7186. Imho the entry should be removed completely and not set to an empty string. @martinjagodic as you approved the changes, could you please take care of #7120 and #7186? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #6918
Since recent changes to image gallery & sorting, file widget value defaulted to an empty array, which caused incorrect structure when single field was used within list. This reverts to how it was before 3.0.