Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My team currently has a fork of decap-cms with several custom plugins, some of them considerably costly in terms of render time. We noticed the render time became unbearably slow when loading a moderately long list (~15 elements) of one of said plugins. After a bit of debugging, we noticed a huge amount of component rerenders while the assets were loading, and the plugin wasn't even visible. The problem is fixed when using the existing prop
isLoadingAsset
to avoid updating the component while the assets are loading. This PR implements that fix.Test plan
yarn test
runs successfullyChecklist
Please add a
x
inside each checkbox: