Fix error import #20
Open
Fix error import #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I moved |
fantix
approved these changes
Jan 28, 2019
|
+1 this pair of changes fixed the same import error for me which I ran into on py3.7. |
|
@fantix would you mind porting @URenko 's patch to aioh2 and make a new release? aioh2 is currently unusable with any recent python3 versions and people are struggling with dependencies. Patches available from https://github.com/URenko/aioh2 URenko@8c1b5ab which are essentially this diff. Example issues on the dohproxy side: Landing this diff and making a new release would also close #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from . import async_taskin #19 is needless and will cause errorImportError: cannot import name 'async_task' from 'aioh2'