Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Thumbnail image too big #1578

Merged
merged 3 commits into from
Sep 21, 2021
Merged

fix: Thumbnail image too big #1578

merged 3 commits into from
Sep 21, 2021

Conversation

LautaroPetaccio
Copy link
Contributor

This PR does the following:

  • Fixes a default value that resulted in all thumbnails to be 1024px in size.
  • Makes the assets be 256px in size.
  • Makes the wearable thumbnails to be 512px in size.
  • Fetches the thumbnail to generate the catalyst image without cache.

@vercel
Copy link

vercel bot commented Sep 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/decentraland/builder/8JoMTHfhKiJooJfyejYwet2EUVj5
✅ Preview: https://builder-git-fix-thumbnail-image-too-big-decentraland1.vercel.app

@cazala cazala merged commit a013996 into master Sep 21, 2021
@cazala cazala deleted the fix/thumbnail-image-too-big branch September 21, 2021 20:56
@coveralls
Copy link

coveralls commented Sep 22, 2021

Pull Request Test Coverage Report for Build 1259259017

  • 1 of 4 (25.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 5.408%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/getScreenshot.ts 0 1 0.0%
src/modules/item/utils.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 1258869761: 0.01%
Covered Lines: 579
Relevant Lines: 8941

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants