Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: entity timestamp #1705

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix: entity timestamp #1705

merged 1 commit into from
Dec 21, 2021

Conversation

cazala
Copy link
Member

@cazala cazala commented Dec 21, 2021

Fixes issue with new /status endpoint where the timestamp ends up being null

@vercel
Copy link

vercel bot commented Dec 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/decentraland/builder/3bn8yhrc53VWYj2dRa9Yqt7Cdsxw
✅ Preview: https://builder-git-fix-timestamp-decentraland1.vercel.app

fzavalia
fzavalia approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@fzavalia fzavalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1607224299

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 15.379%
Files with Coverage Reduction New Missed Lines %
src/modules/item/export.ts 2 20.88%
Totals Coverage Status
Change from base Build 1574746682: -0.004%
Covered Lines: 1705
Relevant Lines: 10063
💛 - Coveralls

@cazala cazala merged commit 6561087 into master Dec 21, 2021
@cazala cazala deleted the fix/timestamp branch December 21, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzavalia fzavalia fzavalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cazala @coveralls @fzavalia