feat: Add MANA approval to the buy items slots flow #1707
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/decentraland/builder/7vcUSYSEYEM8ELVgyzuJ1ubqkxtq |
Pull Request Test Coverage Report for Build 1658645763
💛 - Coveralls |
| @@ -16,6 +16,12 @@ export default class BuyItemSlotsModal extends React.PureComponent<Props, State> | |||
| selectedTierId: undefined | |||
| } | |||
|
|
|||
| onCloseModal = (): void => { | |||
There was a problem hiding this comment.
To follow conventions, I think this should be called handleOnCloseModal right?
| onTierSelected: () => dispatch(clearTiersError()), | ||
| onBeforeClose: () => dispatch(clearTiersError()), |
There was a problem hiding this comment.
This might be coincidental, but given that we have two methods with different names poiting to the same dispatched action, what if we just have onClearTiersError() and call that instead?
There was a problem hiding this comment.
I definitely though about it, but from the perspective of the component as an isolated chunk of code, there's nothing to explicitly clear the errors, so it might be a bit confusing.
| const MANA_SYMBOL = '⏣' | ||
|
|
||
| export function addSymbol(num: string | number) { | ||
| return num > 0 ? `${MANA_SYMBOL} ${num.toString()}` : '' | ||
| } | ||
|
|
||
| export function buildManaAuthorization(address: string, chainId: ChainId, contractName: ContractName): Authorization { |
There was a problem hiding this comment.
Maybe we can test this method?
There was a problem hiding this comment.
Oh, I forgot to add tests to it! Added them.
…ub.com:decentraland/builder into feat/add-mana-approve-modal-to-buy-items-slots
LautaroPetaccio
deleted the
feat/add-mana-approve-modal-to-buy-items-slots
branch
This PR does the following: